feat: long poll api endpoint and user manager #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshinongit
force-pushed
the
feat-poll-active-client
branch
2 times, most recently
from
1ebd5ab to
2bc6010
Compare
oshinongit
changed the title
oshinongit
force-pushed
the
feat-poll-active-client
branch
from
2bc6010 to
d299c8f
Compare
oshinongit
commented
Mar 26, 2024
| @@ -129,37 +131,39 @@ export const SmbEndpointDescription = Type.Object({ | |||
|
|
|||
| export const Endpoint = Type.Object({ | |||
| endpointId: Type.String(), | |||
| sessionDescription: SmbEndpointDescription | |||
| sessionDescription: SmbEndpointDescription, | |||
| isActive: Type.Boolean() | |||
There was a problem hiding this comment.
The isActive attribute on the Endpoint type might be redundant since we will be tracking active status for each user object.
There was a problem hiding this comment.
Actually I change my mind on this. The attribute will be required when we implement the heartbeat logic. A user might have started a new session, in which case the connection itself will still need to be cleaned up if not active.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added a user manager class. One instance of this class is created for every line. There is an event emitter which triggers every time a add/remove function is called on the user manager instance.
-Added a heartbeat endpoint that only resolves if there is a change to the list of users. I am thinking we can use this to implement a long polling from the client. The client will make one request that will linger until it received an updated user list. The client will then immediately make a new request.
-Updated unit tests