Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default arguments are not respected when crafting cache key #172

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Galtozzy
Copy link
Contributor

@Galtozzy Galtozzy commented Jan 8, 2025

Description

  • Fix default arguments are not being respected when crafting cache key
  • Better error message on format key errors (mismatch of key parameters/provided arguments)

Checklist:

If any of these are not checked please leave a succinct reason below

I have ...

  • tested the code
  • added & updated automated tests
  • performed a self-review of own code
  • checked the new code does not generate new warnings

- Better error message on format key errors (mismatch of key parameters/provided arguments)
@Galtozzy Galtozzy force-pushed the bugfix/bound-arguments-apply-defaults branch from 45ac2b3 to 86c1817 Compare January 9, 2025 00:04
Copy link

sonarqubecloud bot commented Jan 9, 2025

@Galtozzy Galtozzy merged commit b469bfe into v/2.0.9 Jan 9, 2025
22 checks passed
@Galtozzy Galtozzy deleted the bugfix/bound-arguments-apply-defaults branch January 9, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant