Make async_threads_module and fesom_C an OBJECT library #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR responds to commit d887a60 by @dsidoren needed to recover performance. This was due to compile flags not being added to the Fortran module
async_threads_module.That revert currently disallows shared libraries as the callback function
async_threads_execute_fcallneeds to be available for the libraryasync_threads_cppwhen built as shared library.The proposed solution is to build
async_threads_cppas object library and have the objects included in libfesom. The same is proposed for libfesom_C (which is only one filepsolve.c).