Don't turn off the flashlight when removing weapons with player_weaponstrip #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduced a change which turns off the flashlight in
RemoveAllItemsI guess it was done so in order to turn off the flashlight in multiplayer when player dies.
This however interferes with how the
player_weaponstripworks which also callsRemoveAllItems. In original Half-Life it doesn't turn off the flashlight.As a middleground I think the flashlight should be turned off if the player is stripped of the suit (which happens in multiplayer via
PackDeadPlayerItems)