Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for search with multiple keywords #23

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

miguelgazela
Copy link
Contributor

PR Details

Adds support for search with multiple keywords

Related Issue

#22

Motivation and Context

Sometimes it's helpful to see multiple requests, that don't share a single keyword, at the same time. For instance, to check the order in which the requests are being made, etc.

How Has This Been Tested

Linked this version to our app and used it to debug an issue with the order of distinct requests. Tried with single and multiple keywords.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@diogobalseiro diogobalseiro merged commit 538d22c into Farfetch:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants