support json schema generation for @JsonUnwrapped (#20) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve tests, the actual fix is in jackson-databind (#271)
|
Sounds good to me; thank you for contribution! One thing that I do need before merging is the Contributor License Agreement (CLA), from https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf which we need for legal reasons. We only need to get it once and it will work for all contributions across projects, versions etc. |
|
Cool, that's great. I just sent you the CLA. |
cowtowncoder
added a commit
that referenced
this pull request
Feb 17, 2015
support json schema generation for @JsonUnwrapped (#20)
cowtowncoder
added a commit
that referenced
this pull request
Feb 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in relation to issue #20 and another pull request in the jackson databind repository.
This change here is rather an improve tests, while the actual fix is in the jackson-databind repository.