Merge pull request #42 from Financial-Times/fix/CI-1517-deep-landscape

fix backgroundColour set for deep-landscape
Financial-Times · Mar 7, 2023 · 6d963a3 · 6d963a3
2 parents 253979b + 01b2437
commit 6d963a3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/lib/get-topper-settings.js b/src/lib/get-topper-settings.js
@@ -114,6 +114,8 @@ const useEditoriallySelectedTopper = (content) => {
 				content.topper.backgroundBox === 'light' ? 'white' : 'black';
 		} else if (!hasDarkBackground(content.topper.backgroundColour)) {
 			backgroundColour = 'white';
+		} else {
+			backgroundColour = 'black';
 		}
 	} else if (
 		content.topper.backgroundColour === 'pink' ||

diff --git a/test/lib/get-topper-settings.test.js b/test/lib/get-topper-settings.test.js
@@ -122,6 +122,21 @@ describe('Get topper settings', () => {
 			expect(topper.backgroundColour).to.equal('white');
 		});
 
+		it('sets the `backgroundColour` to `black` if layout is deep landscape and background is dark', () => {
+			const topper = getTopperSettings({
+				topper: { layout: 'deep-landscape', backgroundColour: 'slate' }
+			});
+
+			expect(topper.backgroundColour).to.equal('black');
+		});
+		it('sets the `backgroundColour` to `white` if layout is deep landscape and background is undefined', () => {
+			const topper = getTopperSettings({
+				topper: { layout: 'deep-landscape' }
+			});
+
+			expect(topper.backgroundColour).to.equal('white');
+		});
+
 		describe('When a background Box is present', () => {
 			it('sets the `backgroundColour` to `white` if layout is deep landscape and background Box is light', () => {
 				const topper = getTopperSettings({