improve error logging: log catched errors

processing/index.ts

@@ -65,6 +65,7 @@ try {
   }
 
   await logTileInfo(params.environment)
-} catch (e) {
-  synologyLogError('Processing failed')
+} catch (error) {
+  synologyLogError(`Processing failed: ${error}`)
+  throw error
 }

processing/steps/download.ts

@@ -76,18 +76,19 @@ export async function downloadFile(fileURL: URL, skipIfExists: boolean) {
   }
 
   if (eTag === (await readPersistent(fileName))) {
-    console.log('Skipped download because the file has not changed')
+    console.log('⏩ Skipped download because the file has not changed.')
     return { fileName, fileChanged: false }
   }
 
   // download file and write to disc
   console.log(`Downloading file "${fileName}"...`)
   const response = await fetch(fileURL.toString())
 
-  if (response.status !== 200 || !response.body) {
-    throw new Error(`Failed to download file. Status code: ${response.status}`)
+  if (!response.ok || !response.body) {
+    throw new Error(`Failed to download file. Status code: ${response.statusText}`)
   }
 
+  // we need to download the file as a stream to avoid memory issues
   const reader = response.body.getReader()
   const writer = file.writer()
   while (true) {

processing/steps/externalTriggers.ts

@@ -28,8 +28,8 @@ export async function clearCache() {
   try {
     await $`rm -rf "/var/cache/nginx/*"`
     console.log('Succesfully cleared the cache.')
-  } catch {
-    console.warn('Clearing the cache failed.')
+  } catch (error) {
+    console.warn(`Clearing the cache failed: ${error}`)
   }
 }
 
@@ -41,7 +41,7 @@ export async function restartTileServer() {
   try {
     await $`docker restart tiles > /dev/null`
     console.log('Succesfully restarted the tiles container.')
-  } catch {
-    throw new Error('Restarting the tiles container failed.')
+  } catch (error) {
+    throw new Error(`Restarting the tiles container failed: ${error}`)
   }
 }

processing/steps/filter.ts

@@ -34,8 +34,8 @@ export async function tagFilter(fileName: string, fileChanged: boolean) {
                   --expressions ${FILTER_EXPRESSIONS} \
                   --output=${filteredFilePath(fileName)} \
                   ${originalFilePath(fileName)}`
-    } catch {
-      throw new Error('Failed to filter the OSM file.')
+    } catch (error) {
+      throw new Error(`Failed to filter the OSM file: ${error}`)
     }
   } else {
     console.log('⏩ Skipping tag filter. The file and filters are unchanged.')
@@ -59,8 +59,8 @@ export async function idFilter(fileName: string, ids: string) {
               --output=${filteredFilePath(ID_FILTERED_FILE)} \
               --verbose-ids ${filteredFilePath(fileName)} \
               ${ids}`
-  } catch {
-    throw new Error('Failed to filter the OSM file by ids.')
+  } catch (error) {
+    throw new Error(`Failed to filter the OSM file by ids: ${error}`)
   }
 
   return ID_FILTERED_FILE

processing/steps/generateTypes.ts

@@ -25,8 +25,8 @@ export async function generateTypes(environment: string, processedTables: string
     await Bun.write(typeFile, tableIdType)
     try {
       await $`bunx prettier -w --config=/processing/.prettierrc ${TYPES_DIR} > /dev/null`
-    } catch {
-      throw new Error('Failed to run prettier on auto generated types')
+    } catch (error) {
+      throw new Error(`Failed to run prettier on auto generated types: ${error}`)
     }
   }
 }

processing/steps/metadata.ts

@@ -24,8 +24,8 @@ export async function getFileTimestamp(fileName: string) {
     const timestamp =
       await $`osmium fileinfo ${filteredFilePath(fileName)} -g header.option.timestamp`.text()
     return timestamp.trim()
-  } catch {
-    throw new Error(`Failed to get timestamp from file ${fileName}`)
+  } catch (error) {
+    throw new Error(`Failed to get timestamp from file "${fileName}": ${error}`)
   }
 }
 

processing/steps/processTopics.ts

@@ -27,8 +27,8 @@ async function runSQL(topic: Topic) {
   if (await Bun.file(psqlFile).exists()) {
     try {
       await $`psql -q -f ${psqlFile}`
-    } catch {
-      throw new Error(`Failed to run SQL file ${psqlFile}`)
+    } catch (error) {
+      throw new Error(`Failed to run SQL file "${psqlFile}": ${error}`)
     }
   }
 }
@@ -50,8 +50,8 @@ async function runLua(fileName: string, topic: Topic) {
               --extra-attributes \
               --style=${luaFile} \
               ${filePath}`
-  } catch {
-    throw new Error(`Failed to run lua file ${luaFile}`)
+  } catch (error) {
+    throw new Error(`Failed to run lua file "${luaFile}": ${error}`)
   }
 }
 

processing/utils/diffing.ts

@@ -12,9 +12,9 @@ export async function getTopicTables(topic: Topic) {
       .text()
       .then((tables) => new Set(tables.split('\n').filter((table) => table !== '')))
     return tables
-  } catch {
+  } catch (error) {
     throw new Error(
-      `Failed to get tables for topic ${topic}. This is likely due to some required columns missing.`,
+      `Failed to get tables for topic "${topic}". This is likely due to some required columns missing: ${error}`,
     )
   }
 }

processing/utils/hashing.ts

@@ -10,8 +10,8 @@ async function computeDirectoryHash(path: string) {
   try {
     const hash = await $`find "${path}" -type f | sort | xargs shasum`.text()
     return hash
-  } catch {
-    throw new Error('Could not compute the hash of the directory')
+  } catch (error) {
+    throw new Error(`Could not compute the hash of the directory "${path}": ${error}`)
   }
 }