Debugging react-usequerystate
#51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
force-pushed
the
debug-querystate
branch
from
327fa01 to
b5642dc
Compare
…on present all the time This is wasteful since we have to query the region every time…
This is not a great solution, because the static data will move to the DB at some point, but for now it is good enough and makes sure we do not query the DB.
This does guard the application against undefined states where the initial URL is invalid. However, it also causes weird state effects. 1. Open page with broken config-param 2. App fixes the config-param and renders fine but does not fix the URL 3. Only once the user triggers a setConfig, the fixed URL is populated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 47ng/nuqs#400
Also related to 47ng/nuqs#399