Update 满足合并需要 #1094
Closed
Update 满足合并需要 #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes by create-pull-request action
fumiama
requested changes
Jan 6, 2025
| panic(err) | ||
| logrus.Infof("[tarot]uri: %s", engine.DataFolder()) | ||
|
|
||
| MajorArcana := engine.DataFolder() + "MajorArcana" |
There was a problem hiding this comment.
不必检测是否存在此文件夹，MkdirAll在文件夹存在时不会报错。直接每次执行即可。对于报错，直接panic(err)，return没用。
There was a problem hiding this comment.
Github源在国内能拉取到的地方能有多少，大部分地区都是timeout，raw.githubusercontent.com的可访问性几乎为0，只有github.io的可访问性比较高，github.com能不能访问纯属看当地sni阻断程度，绝大部分时间都是无法访问
There was a problem hiding this comment.
有没有一种可能，就是说我有办法绕过去，并且已经在zbp实装了。只要DNS正确就能下载，多的就不说了，你自己试试不就知道了。
| } | ||
| } | ||
|
|
||
| MinorArcana := engine.DataFolder() + "MinorArcana" |
| return os.WriteFile(f.Name(), data, 0755) | ||
| }, ctxext.Send(ctx)) | ||
| imgurl := reverse[p] + card.ImgURL | ||
| _, err := engine.GetLazyData(imgurl, true) // 获取数据和错误 |
There was a problem hiding this comment.
直接使用返回的data, 发 base64，即message.ImageBytes(data)
| @@ -319,23 +318,13 @@ func init() { | |||
| }) | |||
| } | |||
|
|
|||
| func poolimg(imgurl, imgname, cache string) (msg message.Segment, err error) { | |||
| imgfile := cache + "/" + imgname + ".png" | |||
| func poolimg(engine *control.Engine, imgurl, cache string) (msg message.Segment, err error) { | |||
There was a problem hiding this comment.
这个函数并无它名字的意义，它只是为了减少代码的修改量而存在，并且对于imgfile的拼凑这个提交的最新的代码为：
imgfile := cache + "/" + imgurl aimgfile := file.BOTPATH + "/" + imgfile，它是为了拼凑出一个合适的路径
There was a problem hiding this comment.
那你应当把函数名和入参名都改了，该改的时候不该说减少修改量，反而影响之后看的人阅读代码。
fumiama
requested changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.