Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify menu partial, remove "settings", make it easier to override default paritial #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

that0n3guy
Copy link

This simplifies things a little bit, but is NOT backwords compatable (but thats good). It makes it so that the user can use whatever format they want for displaying the menu. They can override the default menu partial two different "october" ways. Those 2 ways are listed in the default.htm file:

{#
 #### Options for overriding this file####
 # Option 1:
 # Add this DIRECTLY into your page/layout/paritial, change the __SELF__ below (note: NOT the _self)to your
 #    component alias  (eg. menu.menuTree)
 #
 # See the end of this screencast for more and example: http://octobercms.com/blog/post/mastering-components)
 #
 # Option 2:
 # If your overriding this partial using a paritial in your theme, leave the __SELF__ alone
 # See: https://github.com/octobercms/docs/issues/18)
 #}

This makes the "settings" pointless now.

@that0n3guy
Copy link
Author

I just fixed the issue w/ disabled menu items showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant