Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-graph image and metadata added #1089

Merged
merged 2 commits into from
Jan 8, 2025
Merged

open-graph image and metadata added #1089

merged 2 commits into from
Jan 8, 2025

Conversation

barret-anspach
Copy link
Contributor

Description

This PR adds an open-graph image (and metadata) for Nuka.

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Will test by way of sharing a link to the lander, once this PR is submitted.

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: d59b805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 7:47pm

pnpm-lock.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe your local pnpm version is out of sync -- not sure you'd want to commit this algongside the opengraph work 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan — I'll check it out!

@barret-anspach barret-anspach merged commit 0f6bd41 into main Jan 8, 2025
3 checks passed
@barret-anspach barret-anspach deleted the open-graph branch January 8, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants