add get_namespace_index to Session

[oroulet]

No description provided.

[einarmo]

Okay, this works, but the session actually contains a place where we store a NamespaceMap, and ways to set it, using set_namespace_map.

What if we did:

• Let read_namespace_array store the read namespace map, and return a clone of the NamespaceMap (it already contains methods for working with namespaces that are easier to use than just Vec<String>, and can be extended).
• Have get_namespace_index just always read from the cached namespace map, and return None if no namespace map is present.

That does mean the user must make a dedicated call to fetch the namespace array, but it resolves the question of what the return type from get_namespace_index should be (It'd just be an option).

[oroulet]

I made get_namespace index update namespace in the background... not sure it is a good idea. sounds easier to me. but as you want. anyway who know what they do anyway would query directly the namespace map

[einarmo]

This works, just some nitpicks.

We can add methods for getting directly from the cache without retrieving it from the server later, or make it visible in some way.

[einarmo]

This should probably return an error if any variant isn't a string, that is an error in this case.

[oroulet]

yes. I think I originally copied that code from somewhere. Can fix now

[oroulet]

but once again I need to know what kind of error we should return.
If the project does not define errors, we need to make our own or decide to return the error with statuscode that is used several places

[einarmo]

In this case you can actually define a unit struct for it, or something like struct UnexpectedVariantType(usize) containing the index of the variant that failed or something like that. That's what we do some other places.

[oroulet]

But simple enums/structs are not compatible with stderror and create a lot t of issues isn't it?
Then I would rather use thiserror crate which is anyway a dependency

[oroulet]

I made an MR: As far as I know this is the correct way to do it, but I do not have so much experience with rust

[oroulet]

#18

[einarmo]

Looks good

[oroulet]

@einarmo I pushed right after your approval... so you need to have a look and maybe approve again

[einarmo]

Still fine, provided everything passes 👍