Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused deps + update knip config #3554

Merged
merged 20 commits into from
Jan 10, 2025
Merged

Conversation

maschad
Copy link
Member

@maschad maschad commented Jan 6, 2025

Summary

The original intention of this issue was to resolve any instances of false positives being detected by knip , given quite a few files have changes since the only instance of such was the versions.data.ts which needed to be treated as an entryPoint since it's used in the docs package.

The remainder of the PR removes unused dependencies across packages.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:11pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:11pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 5:11pm

@github-actions github-actions bot added the chore Issue is a chore label Jan 6, 2025
@maschad maschad self-assigned this Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This PR is published in NPM with version 0.0.0-pr-3554-20250106201303

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove the profiling tool?

packages/crypto/package.json Outdated Show resolved Hide resolved
Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertonysmith94 it should've been removed when we removed the benchmark deps I I believe.

@petertonysmith94
Copy link
Contributor

@petertonysmith94 it should've been removed when we removed the benchmark deps I I believe.

@danielbate My understanding is that it's a separate tool to the benchmarking.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Coverage Report:

Lines Branches Functions Statements
76.9%(-0.07%) 70.35%(-0.14%) 74.89%(-0.13%) 76.9%(-0.07%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.69%
(-0.45%)
58.08%
(+0%)
70.21%
(-1.06%)
68.42%
(-0.43%)
🔴 packages/account/src/providers/generated/operations.ts 94.03%
(-0.67%)
100%
(+0%)
81.63%
(-2.04%)
94.51%
(-0.61%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
78.08%
(+1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 76.66%
(+0.26%)
64.4%
(-1.05%)
93.75%
(+0%)
76.66%
(+0.26%)
🔴 packages/account/src/providers/transaction-summary/assemble-transaction-summary.ts 100%
(+0%)
77.77%
(+6.35%)
100%
(+0%)
100%
(+0%)
🔴 packages/account/src/providers/transaction-summary/calculate-tx-fee-for-summary.ts 100%
(+0%)
90%
(-1.66%)
100%
(+0%)
100%
(+0%)
🔴 packages/account/src/providers/transaction-summary/status.ts 100%
(+0%)
93.33%
(+2.43%)
100%
(+0%)
100%
(+0%)
🔴 packages/address/src/address.ts 90.9%
(-0.17%)
86.66%
(+0%)
85.71%
(+0%)
91.07%
(-0.15%)
🔴 packages/address/src/utils.ts 69.23%
(-9.03%)
50%
(-21.42%)
77.77%
(-9.73%)
70.37%
(-8.79%)

@arboleya arboleya enabled auto-merge (squash) January 10, 2025 09:14
@arboleya arboleya merged commit 68ef74d into master Jan 10, 2025
24 checks passed
@arboleya arboleya deleted the mc/chore/knip-fixes branch January 10, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate false positives with Knip
6 participants