[Community] [WithThreeJs] Supports shadow #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports real-time shadow feature.
D8H
requested changes
May 13, 2024
| "version": "1.2.2", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
When you increment the major, you need to explain to users what the breaking changes are and how they should modify their events to make their project work with the new version of the extension.
There was a problem hiding this comment.
@PANDAKO-GitHub did you make this 2.0 because it causes breaking changes to existing games? If so, Davy is asking to describe this in the description. I think that is the only hold up.
There was a problem hiding this comment.
Thank you for your review.
I have updated the version with optimizations for 3D object deletion and added explanations about compatibility.
Supports real-time shadow feature, etc. The "Create 3D Scene", "Load 3D Texture", "Play 3D Sound" and "Create 3D Light" actions have been updated in version 2.0.0. The previous actions with the same names still work but are deprecated. (Look for the⚠️ icon in the event.) Please use the new actions with the same names.
D8H
approved these changes
Jun 4, 2024
|
Thank you for this new update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports real-time shadow feature, etc.