forked from geoschem/Cloud-J
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud-J 8.0.1 #2
Open
lizziel
wants to merge
62
commits into
geos/latest_gcc
Choose a base branch
from
feature/ewlundgr/cloudj_8.0.1
base: geos/latest_gcc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes the requirement of using MODEL_GEOSCHEM if passing vertical grid from parent model. Signed-off-by: Lizzie Lundgren <[email protected]>
# levels with cloud is now passed as an argument in Init_Cldj. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…cloud_from_parent_model Set levels with cloud from parent model
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
RC is now passed back to parent model. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Improve error handling
.zenodo.json - Use the correct license string: "GPL-3.0" - Removed the contributors section, Zenodo doesn't like it - Updated the desription - Added keywords from the Cloud-J repo - Replaced tabs with spaces CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Update the .zenodo.json file for auto-DOI generation upon release
Signed-off-by: Lizzie Lundgren <[email protected]>
gcc 11 is no longer supported in the mac runners. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…code These variables were switched from being read from config file to being hard-coded in the initialization subroutine. This limits flexibility for users of standalone and also of models that embed Cloud-J. The two physical parameters are not passed but are now hard-coded in cldj_cmn_mod.F90 (radius of earth and scale heigh above top). NRANDO is now a locally set variable in cldj_sub_mod.F90 since it is only used for cloud flag 5 which is not recommended, and should not need to be changed anyway except by advanced users. The spherical correction parameters is now set in cldj_cmn_mod.F90 to 2 (refr) since that has been the standard for the last 20 years. NSBIN is also set as a fixed parameter (27) in cldj_cmn_mod.F90 since it is only used in Solar-JX. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…ther Signed-off-by: Lizzie Lundgren <[email protected]>
- atmos_PTClds - for tests.dat is deteled - CJ77_inp.dat is deleted - FJX_spec.dat is updated with new comments and with H2O UV absopritions - FJX_spec_no-xH2O.dat is added, equivalent to FJX_spec.dat but with H2O UV cross-sections zeroed out and history notes removed Signed-off-by: Lizzie Lundgren <[email protected]>
H2O UV absorption is on by default in Cloud-J standalone. In external models the setting will be passed during initialization. Signed-off-by: Lizzie Lundgren <[email protected]>
The outputs of these subroutines are used to prepare inputs to calling CLOUD_JX and not used in GEOS-Chem. Other external models should have their own way to getting climatology to pass to Cloud-J. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…ical Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
This fixes a bug in Cloud-J standalone introduced during v8 development. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…e.F90 Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Feature/cloudj v8
…ault Signed-off-by: Lizzie Lundgren <[email protected]>
…lues Signed-off-by: Lizzie Lundgren <[email protected]>
…r_than_exact_num_jvalues Use JVN_ as max not exact number of J-values
Signed-off-by: Lizzie Lundgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR updates Cloud-J to 8.0.1 for compatibility with GEOS-Chem 14.5.1. See Cloud-J
CHANGELOG.md
for description of changes.