Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-J 8.0.1 #2

Open
wants to merge 62 commits into
base: geos/latest_gcc
Choose a base branch
from
Open

Conversation

lizziel
Copy link
Collaborator

@lizziel lizziel commented Jan 14, 2025

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR updates Cloud-J to 8.0.1 for compatibility with GEOS-Chem 14.5.1. See Cloud-J CHANGELOG.md for description of changes.

lizziel and others added 30 commits June 20, 2024 16:24
This update removes the requirement of using MODEL_GEOSCHEM if
passing vertical grid from parent model.

Signed-off-by: Lizzie Lundgren <[email protected]>
# levels with cloud is now passed as an argument in Init_Cldj.

Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…cloud_from_parent_model

Set levels with cloud from parent model
RC is now passed back to parent model.

Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
.zenodo.json
- Use the correct license string: "GPL-3.0"
- Removed the contributors section, Zenodo doesn't like it
- Updated the desription
- Added keywords from the Cloud-J repo
- Replaced tabs with spaces

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
Update the .zenodo.json file for auto-DOI generation upon release
gcc 11 is no longer supported in the mac runners.

Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel added 28 commits August 12, 2024 16:16
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…code

These variables were switched from being read from config file to being
hard-coded in the initialization subroutine. This limits flexibility for
users of standalone and also of models that embed Cloud-J.

The two physical parameters are not passed but are now hard-coded in
cldj_cmn_mod.F90 (radius of earth and scale heigh above top).

NRANDO is now a locally set variable in cldj_sub_mod.F90 since it is only
used for cloud flag 5 which is not recommended, and should not need to be
changed anyway except by advanced users.

The spherical correction parameters is now set in cldj_cmn_mod.F90 to
2 (refr) since that has been the standard for the last 20 years.

NSBIN is also set as a fixed parameter (27) in cldj_cmn_mod.F90 since it
is only used in Solar-JX.

Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
- atmos_PTClds - for tests.dat is deteled
- CJ77_inp.dat is deleted
- FJX_spec.dat is updated with new comments and with H2O UV absopritions
- FJX_spec_no-xH2O.dat is added, equivalent to FJX_spec.dat but with
  H2O UV cross-sections zeroed out and history notes removed

Signed-off-by: Lizzie Lundgren <[email protected]>
H2O UV absorption is on by default in Cloud-J standalone. In external
models the setting will be passed during initialization.

Signed-off-by: Lizzie Lundgren <[email protected]>
The outputs of these subroutines are used to prepare inputs to
calling CLOUD_JX and not used in GEOS-Chem. Other external models should
have their own way to getting climatology to pass to Cloud-J.

Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
This fixes a bug in Cloud-J standalone introduced during v8 development.

Signed-off-by: Lizzie Lundgren <[email protected]>
…r_than_exact_num_jvalues

Use JVN_ as max not exact number of J-values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants