Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new GEOS-MITgcm configs that has shelfice #68

Merged
merged 2 commits into from
May 29, 2024
Merged

new GEOS-MITgcm configs that has shelfice #68

merged 2 commits into from
May 29, 2024

Conversation

afahadabdullah
Copy link
Member

a new experiment config for GEOS-MITgcm from eccov4r5.

@afahadabdullah afahadabdullah added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Apr 23, 2024
@afahadabdullah afahadabdullah requested a review from amolod April 23, 2024 16:31
@afahadabdullah afahadabdullah self-assigned this Apr 23, 2024
@afahadabdullah afahadabdullah requested a review from a team as a code owner April 23, 2024 16:31
sanAkel
sanAkel approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@sanAkel sanAkel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds code/config falls outside the scope of my work. In any case approving it to advance their work.

@mathomp4
Copy link
Member

Note: I'm pretty sure the CI failures will abate once develop is merged into this branch via Update branch.

@sanAkel
Copy link
Collaborator

sanAkel commented Apr 25, 2024

Note: I'm pretty sure the CI failures will abate once develop is merged into this branch via Update branch.

@afahadabdullah will you do ⬆️ as @mathomp4 suggests.

@afahadabdullah
Copy link
Member Author

Note: I'm pretty sure the CI failures will abate once develop is merged into this branch via Update branch.

@afahadabdullah will you do ⬆️ as @mathomp4 suggests.

@sanAkel yes, let me check with @mathomp4 how to do this. thanks, Santha.

@sanAkel
Copy link
Collaborator

sanAkel commented Apr 26, 2024

@afahadabdullah you don't have to close this PR!

  1. Reopen the PR
  2. Push the button that says something like "merge with develop" and squash your commits or whatever you prefer.

@mathomp4 mathomp4 reopened this May 2, 2024
@sanAkel sanAkel merged commit e089c72 into develop May 29, 2024
9 checks passed
@sanAkel sanAkel deleted the feature/afahad/eccov4r5_mitconfig branch May 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanAkel sanAkel sanAkel approved these changes

@amolod amolod Awaiting requested review from amolod

Assignees

@afahadabdullah afahadabdullah

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afahadabdullah @mathomp4 @sanAkel