Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESMF CMake target to ESMF::ESMF #280

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mathomp4
Copy link
Member

This PR updates the ESMF CMake target to ESMF::ESMF which is the correct canonical target name for ESMF. This is necessary for Spack compatibility. NOTE: This requires ESMF 8.6.1 or later.

This PR updates the ESMF CMake target to `ESMF::ESMF` which is the
correct canonical target name for ESMF. This is necessary for Spack
compatibility. NOTE: This requires ESMF 8.6.1 or later.
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 12, 2024
@mathomp4 mathomp4 self-assigned this Aug 12, 2024
@mathomp4 mathomp4 requested review from a team as code owners August 12, 2024 19:12
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust in Matt!

@mmanyin mmanyin merged commit b1ddf54 into develop Aug 14, 2024
15 checks passed
@mmanyin mmanyin deleted the feature/mathomp4/update-esmf-target branch August 14, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants