Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gigatraj Support #866

Merged
merged 20 commits into from
Jan 9, 2025
Merged

Add Gigatraj Support #866

merged 20 commits into from
Jan 9, 2025

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jan 6, 2025

This PR adds Gigatraj support to GEOSgcm. This is zero-diff to GEOSgcm as enabling Gigatraj requires setting -DBUILD_WITH_GIGATRAJ=ON at CMake time and the default is OFF.

It is dependent on two upstream PRs:

As a placeholder, I've put in components.yaml that it's pointing to develop as the upstream have been merged in. This PR will need updating once tags for GEOSgcm_App and GEOSgcm_GridComp are tagged.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs labels Jan 6, 2025
@mathomp4 mathomp4 self-assigned this Jan 6, 2025
@mathomp4 mathomp4 requested a review from a team as a code owner January 6, 2025 21:02
@mathomp4 mathomp4 requested a review from weiyuan-jiang January 6, 2025 21:03
@mathomp4 mathomp4 removed the Contingent - DNA These changes are contingent on other PRs label Jan 9, 2025
@sdrabenh sdrabenh merged commit e8c4436 into main Jan 9, 2025
15 of 16 checks passed
@sdrabenh sdrabenh deleted the feature/wjiang/GEOS_GigaTraj branch January 9, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants