-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gigatraj Support #866
Merged
Merged
Add Gigatraj Support #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # components.yaml
mathomp4
added
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
Contingent - DNA
These changes are contingent on other PRs
labels
Jan 6, 2025
sdrabenh
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Gigatraj support to GEOSgcm. This is zero-diff to GEOSgcm as enabling Gigatraj requires setting
-DBUILD_WITH_GIGATRAJ=ON
at CMake time and the default isOFF
.It is dependent on two upstream PRs:
As a placeholder, I've put incomponents.yaml
that it's pointing todevelop
as the upstream have been merged in. This PR will need updating once tags for GEOSgcm_App and GEOSgcm_GridComp are tagged.