Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change relative path in lenkf.j to abs path #745

Merged
merged 2 commits into from
Mar 25, 2024
Merged

change relative path in lenkf.j to abs path #745

merged 2 commits into from
Mar 25, 2024

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Mar 25, 2024 •
edited
Loading

This PR addresses issue #742

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner March 25, 2024 14:50
@gmao-rreichle
Copy link
Contributor

Thanks, @weiyuan-jiang. I tested successfully for LDAS_CONUS and also verified that I can submit the batch job from a directory other than the experiment ./run dir.

gmao-rreichle
gmao-rreichle approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but let's coordinate with @mathomp4 and his work to re-org the GEOSldas repo (see #717) before merging

@mathomp4
Copy link
Member

Approving, but let's coordinate with @mathomp4 and his work to re-org the GEOSldas repo (see #717) before merging

My moving-GEOSldas_App should be fairly compatible with this once I re-do it. I think Git will happily merge.

@gmao-rreichle gmao-rreichle merged commit a88c83d into develop Mar 25, 2024
5 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/wjiang/absPath_lenkf.j branch March 25, 2024 18:09
@gmao-rreichle gmao-rreichle mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-rreichle gmao-rreichle gmao-rreichle approved these changes

Assignees
No one assigned
Labels
0-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @gmao-rreichle @mathomp4