Fix some assertions and VK validation errors with the latest SDK v1.3.275. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overdesigned
commented
Mar 9, 2024
overdesigned
commented
- Remove some incorrect flags in D3D12ResourceFlagsToRps.
- Allow non zero-terminated strings to be used as NodeDecl name.
- Allow multiple compatible access flags on the same subresource by the same node.
- Fix some missing and incorrect return code checks.
- Fix incorrect cmd range when printing cmd batches in ScheduleDebugPrintPhase.
- Avoid transitioning unaccessed persistent resources by marking them unaccessed. This caused barriers on currently presenting swapchain images.
- Fix crash in visualizer when graph is empty.
- Fix various validation errors with SDK 1.3.275.
…esources. This caused barriers on presenting swapchain images etc.
Use timeline semaphores to track queue progress. Fix hardcoded swapchain format. Reorder BindPipeline and BindDescriptorSets. Fix push constants ranges.
overdesigned
force-pushed
the
pr/fix_validation_errors
branch
from
022aafb to
e2eaf97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.