Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logic to allow user with any role to remove reports in progress #4608

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Updated logic to allow user with any role to remove reports in progress #4608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90233f4
Updated logic to allow user with any role to remove reports in progress
sambodeme Jan 10, 2025
922fd4c
Merge branch 'main' into fix-for-helpdesk-ticket-6121
sambodeme Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions backend/audit/views/remove_submission_in_progress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from audit.models.models import STATUS
from audit.models.viewflow import SingleAuditChecklistFlow
from audit.models.submission_event import SubmissionEvent
from audit.models.access_roles import ACCESS_ROLES

logger = logging.getLogger(__name__)

Expand All @@ -32,9 +33,9 @@ def get(self, request, *args, **kwargs):
"""
report_id = kwargs["report_id"]
sac = SingleAuditChecklist.objects.get(report_id=report_id)

role_values = [role[0] for role in ACCESS_ROLES]
if not Access.objects.filter(
email=request.user.email, sac=sac, role="editor"
email=request.user.email, sac=sac, role__in=role_values
).exists():
raise PermissionDenied("Only authorized auditors can remove audits.")

Expand Down
Loading