Audit Deletion Finalized Designs #4640
Conversation
Rework "Audit submissions" page. Start button to top. Icons and copy. "Submission checklist" page includes delete button and modal. Circular icon component.
New folder for FAC-specific icons. Regenerate sprite.svg to include all usa, uswds, and fac icons.
Compound icons can be their own icon!
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.📝 Plan generated in Pull Request Checks #4253 |
|
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2025-01-23T20:11:31Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.📝 Plan generated in Pull Request Checks #4253 |
Break modals into their own component files, update references
Practically, it will always exist. But we don't want to have to set the value for every possible test.
Always display helper text Initialize audit with new workflow Minor fixes
|
It looks like when a submission is locked the deletion modal just takes you to the submission progress page. Are deletions still allowed when a submission is locked? |
backend/audit/templates/audit/audit_submissions/confirm_deletion_modal.html
Outdated
Show resolved
Hide resolved
| id="delete-submission" | ||
| class="usa-button usa-button--secondary" | ||
| value="Permanently Delete" /> | ||
| <a class="usa-button usa-button--unstyled margin-left-2" id="cancel-start-submission" aria-label="Close this window" data-close-modal>Cancel</a> |
There was a problem hiding this comment.
I remember the a11y tests don't like these unstyled buttons because it's only distinguishable by text color. That's why a bunch had to become restyled:
Similar for other cancel buttons in the PR.
There was a problem hiding this comment.
That's interesting! The PR a11y checks don't catch that, but I agree with you! I switched the cancel buttons from this PR to be outlined instead of unstyled.
Edit: I updated the recording in the description as well
There was a problem hiding this comment.
We should probably comb the app at some point and make them all uniform. Honestly, it can be its own component at this point.
EOF newlines Move deletion modal up a level, use it in the checklist
These are also in progress, from the POV of the user.
Minimum allowed line rate is |
| <svg class="usa-icon usa-icon--size-3 margin-right-1" | ||
| aria-hidden="true" | ||
| focusable="false" |
There was a problem hiding this comment.
I know Dan just fixed something recently with form fields being displayed, and i recall aria-hidden in that too.
Just checking that this is hidden and not selectable and working correctly. When I tried your branch locally, everything looked ok, but just thought I'd confirm.
| {% else %} | ||
| {% if data.in_progress_audits %} | ||
| <h1 class="font-sans-xl">Audits in progress</h1> | ||
| <div class="grid-row margin-bottom-6" tabindex="0"> | ||
| <h1 class="font-sans-xl display-inline-flex"> |
There was a problem hiding this comment.
I don't suspect we'll use these sections anywhere else, but would it make sense to pull it out into their own separate html files too?
| aria-hidden="true" | ||
| focusable="false" | ||
| role="img"> |
There was a problem hiding this comment.
github is showing some extra characters here, I suspect /t (tabs)?
| STATUS.IN_PROGRESS, | ||
| STATUS.READY_FOR_CERTIFICATION, | ||
| STATUS.AUDITOR_CERTIFIED, | ||
| STATUS.AUDITEE_CERTIFIED, | ||
| STATUS.CERTIFIED, |
There was a problem hiding this comment.
This was changed in a few places, and I saw one update to the tests. Is that one test update enough to give us coverage for all the times this was changed?
Audit Deletion Finalized Designs
A better title is "I fought icons for a while and we called it a draw."
Issue: #4592
Changes:
sprite.svghas been regenerated to include all FAC and USWDS iconssprite.svgby eightHow to test:
If you've deleted a submission and you want it back, for easier testing, youy can switch it back to "in_progress" at the DB level.
If icons appear broken, make sure your staticfiles folder has been regenerated recently.
python manage.py collectstatic --> 'yes'If they are still broken, make sure you are hard refreshing the page. Also try visiting a new page and coming back, as that fixed some things for me. Chrome likes to hold onto (potentially old) images to save on download time.
Recording:
Now with new buttons!
Screen.Recording.2025-01-23.at.3.25.01.PM.mov
Screenshots:
When one has zero audit submissions, the helper alert still appears
PR Checklist: Submitter
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR Checklist: Reviewer
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.
Pre Merge Checklist: Merger
-/+ resource "null_resource" "cors_header"should be destroying and recreating its self and~ resource "cloudfoundry_app" "clamav_api"might be updating itssha256for thefac-file-scannerandfac-av-${ENV}by default.main.