Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15354: Upgrade Netlify references #1424

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Dec 30, 2024

🎫 Ticket

LG-15354

🛠 Summary of changes

  1. Upgrades the version of the NetlifyCMS.
  2. Moves the referenced JavaScript to our server.

@jc-gsa jc-gsa force-pushed the LG-15354-upgrade-netlify-references branch from ce38abc to 4fa4b44 Compare December 30, 2024 21:08
@@ -12,7 +12,7 @@

<body>
<!-- Include the script that builds the page and powers Netlify CMS -->
<script src="https://unpkg.com/netlify-cms@^2.0.0/dist/netlify-cms.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really glad we're moving away from this CDN!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Reviewing some additional changes and dependencies. Will add another update.

@jc-gsa jc-gsa closed this Dec 31, 2024
@aduth
Copy link
Member

aduth commented Jan 6, 2025

Will this upgrade include migrating from Netlify CMS to Decap CMS (current version 3.4.0), since project ownership / name was changed? I don't see any mention of it in the ticket.

@jc-gsa jc-gsa reopened this Jan 7, 2025
@jc-gsa jc-gsa force-pushed the LG-15354-upgrade-netlify-references branch from f381d73 to aebee5b Compare January 7, 2025 17:51
@jc-gsa jc-gsa closed this Jan 7, 2025
This reverts commit aebee5b.
@jc-gsa jc-gsa reopened this Jan 8, 2025
@jc-gsa
Copy link
Contributor Author

jc-gsa commented Jan 10, 2025

Will this upgrade include migrating from Netlify CMS to Decap CMS (current version 3.4.0), since project ownership / name was changed? I don't see any mention of it in the ticket.

@aduth This PR intentionally updates to netlify-cms-2.10.192, to be followed by additional updates.

I have a question here before merge.

@jc-gsa jc-gsa requested a review from aduth January 10, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants