Help Improve Refactor #165
Conversation
… with UX team's suggestions.
…edback - Implemented USWDS table and styling
| <main class="main-content"> | ||
| <div class="srt-title-padding"> | ||
| <a [routerLink]="['/solicitation/report']" class="back-link"> | ||
| < Back to Solicitation Review Results for Section 508 Requirements |
There was a problem hiding this comment.
I'm thinking we could add a Google Analytics function to track this click if we think it is necessary.
There was a problem hiding this comment.
Good idea!
after my next commit, we'll be able to track:
- Back navigation click -
navbar_solicitation_report - Solicitation number link clicks -
solicitation_link - Feedback form submissions -
feedback_submit
src/app/solicitation/summary/help-us-improve/help-us-improve.component.html
Outdated
Show resolved
Hide resolved
| this.surveyModel.push(''); | ||
| } | ||
| // Remove duplicates based on ID | ||
| this.surveys = [...new Map(data.map(item => [item.ID, item])).values()] |
There was a problem hiding this comment.
Looking at this, why don't we just have restriction in the database not allowing the same ID to be submitted? Seems like more work on the API server when we could just make sure we have that db constraint in place.
There was a problem hiding this comment.
Makes perfect sense! I'll plan to do the following:
- Add the unique constraint to the surveys table
- Remove the duplicate filtering from the frontend
There was a problem hiding this comment.
Duplicate Surveys Issue Resolved
I compared my local database with the production database and discovered that the production environment contained only the correct three survey entries. My local database, however, had six entries, duplicating the initial three. This discrepancy explains the duplicate display we were observing. Since we currently maintain a fixed set of surveys and don't foresee adding new ones in the immediate future, we can simplify the solution by addressing the data directly and removing redundant frontend logic.
Actions Taken:
- Corrected the
Surveystable in the database to match production (3 unique rows). - Removed unnecessary duplicate filtering from the frontend Angular code
- Updated
getSurveysfunction (sorting by ID added).
Unique Constraint on hold:
Given the fixed set of surveys, I've decided to postpone adding a unique constraint to the id column. If our requirements change and we need to add surveys dynamically, I can revisit adding the constraint then.
Thanks for suggesting the database constraint approach! It helped pinpoint the root cause.
| try { | ||
| const navigation = this.router.getCurrentNavigation(); | ||
| if (navigation?.extras?.state?.['solicitation']) { | ||
| const data = navigation.extras.state['solicitation']; |
There was a problem hiding this comment.
Will we run into issues with trying to change the values inside the "const"? I thought "const" are not able to be reassigned but not sure how that affects the underlining values.
Additional, did you confirm that the changes made in one function carries onto the next function because sometimes if the variable scoping is off it would result in no underlining changes actually making its way through each function call.
Feedback Form Updates
Overview
Updates feedback form component to align with UI team recommendations.
Key Changes
User Interface
Technical Updates
Testing Completed ✓
Ready for review.