Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old 32x/64x/png/gradiented circuitry textures with better 16x ones #3509

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

bluhbipo
Copy link
Member

@bluhbipo bluhbipo commented Nov 17, 2024

Mainframes suck. among other things
they're ugly
i have made them better
BEFORE
image
AFTER
image
*note, the photonically enriched wafer is animated correctly, this screencap is just of a bad frame

all pngs and 32x nonsense has been boomed and replaced with beautiful functionally identical 16x textures

the mainframe is of particular importance that its shape was mimiced as well as possible, since people often dislike change and mainframes are a core aspect of the game. the design we came up with was workshopped over several hours through the intellectual contributions of several texture dev and main dev people.

here is what the new optical mainframe looks like fully animated:

opticalmainframe

i do not have the resources to figure out how the hell to screen record. majority of the circuits are still animated ala the previous change by the wonderful terra, but i did not animate textures that i did not believe i could faithfully represent in 256 pixels. this is a job for someone who isnt me

t3 circuits, the computers remain non 16x. why? because they fit in the art style and are too iconic to change. i grappled with perhaps extending the texture of the workstation to all other tiers because i like how it looks, but again, i do not want to poke the hornets nest of "old thing good, new thing bad"

the wafer texture was again workshopped over days via the intellectual contributions of many devs both of texture and code alike. the cut wafer texture sucks but its whatever at least it is not a 64x monstrosity

the earlygame circuit components have been made to look not stupid and png, and later on, glass tubes for all your wetware board needs no longer look ugly as all hell.

this modpack is worthy of the polish that a modern minecraft modpack deserves, and as such, the coloring and shading on the old circuit textures that arent mainframes have been updated in line with a modern understanding of pixel art color theory. wetwares appear more pink because it looks like flesh and we all thought that was cute.

this pr has a portion of it already accepted, for the new masks for beamline. also. i dont know where the pico wafers are stored but they will need to have their textures updated too.

THIS PR IS now tested! yippee!!.

credit to our resident epic artist bluehero for the gallium arsenide crystal textures.

@BlueHero233 BlueHero233 added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 17, 2024
@Dream-Master Dream-Master added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 18, 2024
@Dream-Master Dream-Master requested a review from a team November 18, 2024 07:30
Copy link
Member

@GDCloudstrike GDCloudstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After going through multiple feedback cycles, I think this turned out great

Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We not add this in 2.7.0
Some changes i not agree with. I will give a detailed feedback later

@wlhlm
Copy link
Member

wlhlm commented Nov 20, 2024

Larger than 16px textures are a pet peeve of mine. Thank you for making the base textures more consistent. ❤️

@AbdielKavash
Copy link
Member

Could you post a picture of the glass tube/vacuum tube in a machine UI? One of my pet peeves is that the old texture blends into the machine slot background so well as to appear nearly invisible. I remember several people getting their circuit recipes wrong because they didn't even realize that a vacuum tube is needed from the NEI recipe. It would be nice to have this corrected as well.

@bluhbipo
Copy link
Member Author

some of the circuit changes did not make it into this nightly because i forgot that the images are in multiple folders but only one is drawn from in the final texture! effects transitor, capacitor, and vacuum tube

@Dream-Master
Copy link
Member

some of the circuit changes did not make it into this nightly because i forgot that the images are in multiple folders but only one is drawn from in the final texture! effects transitor, capacitor, and vacuum tube

can you update it and i can test it local?

@bluhbipo
Copy link
Member Author

@Dream-Master should work now
vac tube legs i made much darker so they hopefully are more visible, and the circuit parts were shaded

@Dream-Master
Copy link
Member

sorry i am on it just delayed by a few real life issues i need to do first

@Dream-Master
Copy link
Member

sorry for the long delay i will check this this weekend for sure @bluhbipo

@Dream-Master
Copy link
Member

why this one have different colors and not use a gray scale for all circuits and only the inner color differs?
image
image
image
orginal texture keep the color like:
image
image

@Dream-Master
Copy link
Member

Wafers looks now ok
transistor and capacitor looks better now not sure the shadow can be added in some way
Only Diode and Risitor look very flat. Need to compare to old texture
Tubes are ok now
Bio Mainframe still has no animation
Gallium arsenide crystals looks now ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants