Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo from Babbit to Babbitt #3825

Closed
wants to merge 5 commits into from
Closed

Conversation

mak8427
Copy link
Contributor

@mak8427 mak8427 commented Jan 18, 2025

@serenibyss serenibyss added the bug fix Fix a bug. Please link it in the PR. label Jan 18, 2025
@serenibyss
Copy link
Member

serenibyss commented Jan 19, 2025

@mak8427 Sorry, not quite what I meant:

public static final Material BABBIT_ALLOY = new Material(
        "Babbit Alloy", // Material Name    <--- This line cannot change
        MaterialState.SOLID, // State
        null, // Material Colour
        268, // Melting Point in C
        // ...

The variable name is fine to change, though its not player-facing so I don't have a strong opinion on if it needs to be changed.

@Dream-Master Dream-Master requested a review from a team January 20, 2025 12:51
@mak8427
Copy link
Contributor Author

mak8427 commented Jan 20, 2025

@serenibyss Yes at this point if it is not possible to change the registry name i think it's not useful anymore

@serenibyss
Copy link
Member

Alright, I think we should close this PR then. Thanks for the effort though!

@serenibyss serenibyss closed this Jan 20, 2025
@mak8427 mak8427 deleted the patch-1 branch January 20, 2025 17:34
@mak8427
Copy link
Contributor Author

mak8427 commented Jan 20, 2025

Sure, thanks for your support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants