Add Pipe Swapping functionality #3836
Open
+148
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dream-Master
added
the
🚧 Testing on Zeta
Dream-Master
added
the
enhancement
Lyfts
requested changes
Jan 22, 2025
src/main/java/gregtech/api/metatileentity/implementations/MTEFluid.java
Outdated
Show resolved
Hide resolved
serenibyss
reviewed
Jan 25, 2025
| if (message.length() > 0) { | ||
| GTUtility.sendChatToPlayer( | ||
| aPlayer, | ||
| StatCollector.translateToLocal("GT5U.item.pipe.swap") + message.toString()); |
There was a problem hiding this comment.
Suggested change
| StatCollector.translateToLocal("GT5U.item.pipe.swap") + message.toString()); | |
| StatCollector.translateToLocal("GT5U.item.pipe.swap") + " " + message.toString()); |
Comment on lines
+495
to
+496
| // Preserve connections | ||
| newPipe.mConnections = oldConnections; |
There was a problem hiding this comment.
We also need to transfer over mDisableInput here so that the directional flow settings are preserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the same functionality discussed here but for pipes : #3826
-Feature: Swap different pipes with ctrl+rightclick