Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve UI/UX for removing runs from the schedule without deleting them [#186669498] #634

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

uraniumanchor
Copy link
Collaborator

Contributing to the Donation Tracker

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Issue from Pivotal Tracker

https://www.pivotaltracker.com/story/show/186669498

Description of the Change

Both some frontend and backend changes here, firstly the frontend displays a different icon rather than 'X' for removing a run from the schedule (it implies deletion when that's not the case), and adjusted the current move functionality to accept null for the destination, which means to remove the run from the schedule, rather than explicitly setting the order to null via the edit api. It makes the move logic a little more centralized. I still plan on making it a v2 run verb, but the edit api for runs on v2 isn't complete yet, so I'll probably handle it as part of that.

The primary purpose of this change means that removing a run from the schedule via the command api correctly fills in the hole for starttime for any runs that were after it, but it also help with general cleanup.

Verification Process

Dragging runs around with the schedule editor works as expected, especially when removing runs from the schedule.

@uraniumanchor uraniumanchor force-pushed the 186669498-better-run-moving branch from 28a93e1 to 7dc8bf4 Compare December 13, 2023 02:44
@uraniumanchor uraniumanchor force-pushed the 186669498-better-run-moving branch from 7dc8bf4 to 981ba7a Compare December 13, 2023 02:55
@uraniumanchor uraniumanchor added this pull request to the merge queue Dec 13, 2023
Merged via the queue into master with commit 60435b0 Dec 13, 2023
15 checks passed
@uraniumanchor uraniumanchor deleted the 186669498-better-run-moving branch December 13, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant