improve UI/UX for removing runs from the schedule without deleting them [#186669498] #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Donation Tracker
Issue from Pivotal Tracker
https://www.pivotaltracker.com/story/show/186669498
Description of the Change
Both some frontend and backend changes here, firstly the frontend displays a different icon rather than 'X' for removing a run from the schedule (it implies deletion when that's not the case), and adjusted the current move functionality to accept
null
for the destination, which means to remove the run from the schedule, rather than explicitly setting the order to null via the edit api. It makes the move logic a little more centralized. I still plan on making it a v2 run verb, but the edit api for runs on v2 isn't complete yet, so I'll probably handle it as part of that.The primary purpose of this change means that removing a run from the schedule via the command api correctly fills in the hole for
starttime
for any runs that were after it, but it also help with general cleanup.Verification Process
Dragging runs around with the schedule editor works as expected, especially when removing runs from the schedule.