Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interview tweaks [#186375541] #638

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

uraniumanchor
Copy link
Collaborator

@uraniumanchor uraniumanchor commented Dec 22, 2023

Contributing to the Donation Tracker

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Issue from Pivotal Tracker

https://www.pivotaltracker.com/story/show/186375541

Description of the Change

Some tweaks/additions to the Interview model were requested. This implements said changes.

While was at it I moved an Interstitial helper to the QuerySet where it belongs.

Verification Process

API endpoint returns the new field, honors new public flag (with permissions checks for returning all interviews), admin page works as expected.

- exclude `clips` from form
- add `public` and `prerecorded` fields
- add `all` parameter to api to retrieve private interviews

[#186375541]
@uraniumanchor uraniumanchor force-pushed the 186375541-interview-tweaks branch from 62b3851 to 7e48837 Compare December 22, 2023 00:17
@uraniumanchor uraniumanchor added this pull request to the merge queue Dec 22, 2023
Merged via the queue into master with commit 800147b Dec 22, 2023
16 checks passed
@uraniumanchor uraniumanchor deleted the 186375541-interview-tweaks branch December 22, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant