-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request]: Full-width media #180
Comments
I think square could work, but I would not force an aspect ratio for landscape images, and just show the whole image instead, i.e. images taller than 1:1 would be scaled up and clipped, while images wider than 1:1 would be scaled down and shown without cropping (maybe up to a minimum height of like 100px or so, after which they should probably be scaled up and cropped to keep them a reasonable aspect ratio). |
It just makes the attachment bigger, it does not follow the previous comment #180 (comment) so I left it open (unless it's good enough as is?) |
Mmmh, not sure I follow what it doesn't do to be honest :D |
Currently the attachment is either
✔️ cover takes care of it
❌ The following image will look like this while you probably are looking for something like this |
Ah, gotcha! Thanks for explaining, and yes that is what I had in mind :) |
Describe the request
It's a bit odd that images only use half the width when there's just one, especially at narrower widths. Could we special case the single image case and use the full wdith?
Implementation Details
The text was updated successfully, but these errors were encountered: