Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aria label improvements #1226

Merged
merged 15 commits into from
Dec 14, 2024
Merged

feat: aria label improvements #1226

merged 15 commits into from
Dec 14, 2024

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Nov 28, 2024

rel: #1164

Long way to go but I'm fixing everything I can based on the Matrix feedback.

Specifically so far:

  • Pressing down from the menu button would focus on the scrolledview and not its content, fixed
  • On narrow mode, the sidebar reveal button did not have a tooltip text (and therefore no aria label) that described it
  • Moved accessible roles to widgetclass constructor
  • Fixed wrong or missing accessible roles: markupview should be 'generic' as it's a container that can have multiple widgets and not a label. richlabel became a 'label' with relations to its emojilabel
  • Fixed spoiler revealing resetting the focus position to the parent, when it should be the markupview. This is a bit tricky, as I had to make it focusable, but boxes arent really. Needs more testing but I added an experiment that makes all its children labels focusable instead as a workaround
  • Post avatars had the same tooltip text as post names "Open %s's profile", when they open the mini profile instead and not the full one
  • added an experiment with the post buttons labels BUT, i cant make them drop the label relation with the child, even though I explicitly set the label myself 🤷

@GeopJr GeopJr marked this pull request as ready for review December 14, 2024 18:00
@GeopJr GeopJr merged commit 3746c97 into main Dec 14, 2024
5 checks passed
@GeopJr GeopJr deleted the feat/aria-label-improvements branch December 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant