Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove back arrow from sidebar items #648

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Nov 19, 2023

including the fake ones

fix: #604

@GeopJr GeopJr merged commit 472cec6 into main Nov 19, 2023
5 checks passed
@GeopJr GeopJr deleted the feat/remove-back-arrow-from-sidebar-items branch November 19, 2023 20:51
@danialbehzadi
Copy link
Contributor

If back buttons are removed, there should be sidebar button or user will be stuck on that page for ever!

@GeopJr
Copy link
Owner Author

GeopJr commented Dec 23, 2023

The back buttons are removed from sidebar items only, these ones:
image

The reason is that there can only be one active at a time anyway. If you are at "Home" and select "Bookmarks", you can go back by selecting "Home".

Nested pages still have back buttons, e.g. "Home" => "Bookmarks" => open a post => "Thread" (has back button) ===back===> "Bookmarks"

@danialbehzadi
Copy link
Contributor

If you are at "Home" and select "Bookmarks", you can go back by selecting "Home".

No. I can not, since there is no sidebar button there to select "Home" from. I'm stuck in "Bookmarks" page. Sometimes swiping the page to the left (In RTL locale) will act as a back button and lead me to "Home".

@GeopJr
Copy link
Owner Author

GeopJr commented Dec 24, 2023

I see what you mean now (/ that it only happens on mobile/narrow mode), thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button on top-level views
2 participants