Skip to content

Commit

Permalink
Remove some outdated TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
JuhoErvasti committed Nov 4, 2024
1 parent af9170e commit 7ba46e9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions fvh3t/core/gate_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ def create_gates(self) -> None:
counts_negative_field_idx: int = self.__layer.fields().indexOf(self.__counts_negative_field)
counts_positive_field_idx: int = self.__layer.fields().indexOf(self.__counts_positive_field)

# TODO: Check that these are bool fields

gates: list[Gate] = []

for feature in self.__layer.getFeatures():
Expand Down
1 change: 0 additions & 1 deletion fvh3t/core/trajectory_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,6 @@ def create_trajectories(self, filter_expression: str | None) -> None:
self.__trajectories = tuple(trajectories)

def as_line_layer(self) -> QgsVectorLayer | None:
# TODO: can this be a memory layer?
line_layer = QgsVectorLayer("LineString?crs=3067", "Line Layer", "memory")

line_layer.startEditing()
Expand Down
7 changes: 3 additions & 4 deletions fvh3t/fvh3t_processing/count_trajectories.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,9 @@ def processAlgorithm( # noqa N802
start_time: QDateTime = self.parameterAsDateTime(parameters, self.START_TIME, context)
end_time: QDateTime = self.parameterAsDateTime(parameters, self.END_TIME, context)

# TODO: Currently the datetime widget doesn't allow the user to set the seconds
# so normalize them to 0 seconds, because they are being set seemingly
# randomly leading to odd results. We need to check if selecting the time by
# minutes is OK and if not we might need to write a custom widget
# the datetime widget doesn't allow the user to set the seconds and they
# are being set seemingly randomly leading to odd results...
# so set 0 seconds manually

zero_s_start_time = start_time.time()
zero_s_start_time.setHMS(zero_s_start_time.hour(), zero_s_start_time.minute(), 0)
Expand Down

0 comments on commit 7ba46e9

Please sign in to comment.