Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

66 add export to json script #72

Merged
merged 7 commits into from
Nov 6, 2024
Merged

66 add export to json script #72

merged 7 commits into from
Nov 6, 2024

Conversation

msorvoja
Copy link
Collaborator

@msorvoja msorvoja commented Nov 6, 2024

Fixes #66

@msorvoja msorvoja requested a review from JuhoErvasti November 6, 2024 08:10
@msorvoja msorvoja linked an issue Nov 6, 2024 that may be closed by this pull request
Add export to JSON script #66
Closed
JuhoErvasti
JuhoErvasti requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@JuhoErvasti JuhoErvasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are needed to match the JSON schema, other than that looks great!

fvh3t/core/gate_layer.py Outdated Show resolved Hide resolved
fvh3t/fvh3t_processing/export_to_json.py Outdated Show resolved Hide resolved
fvh3t/fvh3t_processing/export_to_json.py Outdated Show resolved Hide resolved
fvh3t/fvh3t_processing/export_to_json.py Outdated Show resolved Hide resolved
tests/processing/test_export_to_json.py Outdated Show resolved Hide resolved
@msorvoja
Copy link
Collaborator Author

msorvoja commented Nov 6, 2024

@JuhoErvasti Made the requested changes. Btw, currently speed is km/h and acceleration is m/s². Should either of them be converted?

@JuhoErvasti
Copy link
Collaborator

@msorvoja Good point! The acceleration is fine, but the speed needs to be in m/s

@JuhoErvasti
Copy link
Collaborator

@msorvoja Can you change it to m/s? I'm okay to merge after that

@JuhoErvasti JuhoErvasti merged commit a88e12f into main Nov 6, 2024
5 checks passed
@JuhoErvasti JuhoErvasti deleted the 66-add-export-to-json-script branch November 6, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuhoErvasti JuhoErvasti JuhoErvasti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add export to JSON script
2 participants
@msorvoja @JuhoErvasti