-
Notifications
You must be signed in to change notification settings - Fork 18
Add Cloud Functions #24
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 98.98% 98.67% -0.32%
==========================================
Files 1 4 +3
Lines 99 227 +128
==========================================
+ Hits 98 224 +126
- Misses 1 3 +2
Continue to review full report at Codecov.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than a few nits.
src/util.js
Outdated
@@ -106,7 +105,8 @@ function cleanLabels(issue, opts) { | |||
*/ | |||
function getIssueInfo(issue) { | |||
try { | |||
const text = issue.title + ' ' + issue.body; | |||
const raw = issue.title + ' ' + issue.body; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a spot? 😛
Fixes #23