Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SQLTools for BigQuery #42

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

archiewood
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Aug 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iennae
Copy link
Collaborator

iennae commented Aug 10, 2023

@archiewood

Thanks for your contribution. We appreciate the participation in the community.

As part of our practice of curation, we select projects that have more than 1 contributor. Additionally, when submitting your own software, we'd like to see that it has a healthy ecosystem.

Please do share in the future once your project has more contributors/use.

Thank you,

Jennifer

@iennae iennae closed this Aug 10, 2023
@archiewood
Copy link
Contributor Author

archiewood commented Aug 10, 2023

Hey @iennae,

Apologies, I could have been clearer for this.

SQLTools is a widely used open source project with:

I recently contributed the BigQuery driver to this project, as we use BQ at work, and it didn't yet have a driver for SQLTools

The way the project is structured, each driver is a separate repo, and I included the link to the BQ specific driver, though it may have been more suitable to add the parent project.

If you still feel it's not an appropriate addition, that's fine, happy to leave this!

@iennae iennae reopened this Aug 10, 2023
@iennae
Copy link
Collaborator

iennae commented Aug 10, 2023

Thanks for the added context, let me revisit.

@archiewood
Copy link
Contributor Author

Let me know if there's anything more you need here

@tswast tswast added the automerge Summon MOG for automerging label Oct 13, 2023
@tswast tswast self-requested a review October 13, 2023 21:40
@tswast
Copy link
Collaborator

tswast commented Oct 13, 2023

Looks like we need to make some changes to the linter. Lot's of "Not compatible with your version of node/npm" errors.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 14, 2023
@rsamborski rsamborski merged commit 06dc558 into GoogleCloudPlatform:main Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants