-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(json): Add json_object_keys
function.
#5382
Open
linyihai
wants to merge
1
commit into
GreptimeTeam:main
Choose a base branch
from
linyihai:json-object-keys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+207
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
173 changes: 173 additions & 0 deletions
173
src/common/function/src/scalars/json/json_object_keys.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
// Copyright 2023 Greptime Team | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use std::fmt::{self, Display}; | ||
|
||
use common_query::error::{InvalidFuncArgsSnafu, Result, UnsupportedInputDataTypeSnafu}; | ||
use common_query::prelude::Signature; | ||
use datafusion::logical_expr::Volatility; | ||
use datatypes::data_type::ConcreteDataType; | ||
use datatypes::prelude::VectorRef; | ||
use datatypes::scalars::ScalarVectorBuilder; | ||
use datatypes::vectors::{MutableVector, StringVectorBuilder}; | ||
use snafu::ensure; | ||
|
||
use crate::function::{Function, FunctionContext}; | ||
|
||
/// Get all the keys from the JSON object. | ||
#[derive(Clone, Debug, Default)] | ||
pub struct JsonObjectKeysFunction; | ||
|
||
const NAME: &str = "json_object_keys"; | ||
|
||
impl Function for JsonObjectKeysFunction { | ||
fn name(&self) -> &str { | ||
NAME | ||
} | ||
|
||
fn return_type(&self, _input_types: &[ConcreteDataType]) -> Result<ConcreteDataType> { | ||
Ok(ConcreteDataType::string_datatype()) | ||
} | ||
|
||
fn signature(&self) -> Signature { | ||
Signature::exact( | ||
vec![ConcreteDataType::json_datatype()], | ||
Volatility::Immutable, | ||
) | ||
} | ||
|
||
fn eval(&self, _func_ctx: FunctionContext, columns: &[VectorRef]) -> Result<VectorRef> { | ||
ensure!( | ||
columns.len() == 1, | ||
InvalidFuncArgsSnafu { | ||
err_msg: format!( | ||
"The length of the args is not correct, expect exactly one, have: {}", | ||
columns.len() | ||
), | ||
} | ||
); | ||
let jsons = &columns[0]; | ||
|
||
let size = jsons.len(); | ||
let mut results = StringVectorBuilder::with_capacity(size); | ||
|
||
for i in 0..size { | ||
let json = jsons.get_ref(i); | ||
match json.data_type() { | ||
// JSON data type uses binary vector | ||
ConcreteDataType::Binary(_) => { | ||
if let Ok(Some(json)) = json.as_binary() | ||
&& let Ok(json) = jsonb::from_slice(json) | ||
&& let Some(keys) = json.object_keys() | ||
{ | ||
results.push(Some(&keys.to_string())); | ||
} else { | ||
results.push(None) | ||
} | ||
} | ||
|
||
_ => { | ||
return UnsupportedInputDataTypeSnafu { | ||
function: NAME, | ||
datatypes: columns.iter().map(|c| c.data_type()).collect::<Vec<_>>(), | ||
} | ||
.fail(); | ||
} | ||
} | ||
} | ||
|
||
Ok(results.to_vector()) | ||
} | ||
} | ||
|
||
impl Display for JsonObjectKeysFunction { | ||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
write!(f, "JSON_OBJECT_KEYS") | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use std::sync::Arc; | ||
|
||
use common_query::prelude::TypeSignature; | ||
use datatypes::vectors::BinaryVector; | ||
|
||
use super::*; | ||
|
||
#[test] | ||
fn test_json_object_keys_function() { | ||
let json_object_keys = JsonObjectKeysFunction; | ||
|
||
assert_eq!("json_object_keys", json_object_keys.name()); | ||
assert_eq!( | ||
ConcreteDataType::string_datatype(), | ||
json_object_keys | ||
.return_type(&[ConcreteDataType::string_datatype()]) | ||
.unwrap() | ||
); | ||
|
||
assert!(matches!(json_object_keys.signature(), | ||
Signature { | ||
type_signature: TypeSignature::Exact(valid_types), | ||
volatility: Volatility::Immutable | ||
} if valid_types == vec![ConcreteDataType::json_datatype()], | ||
)); | ||
|
||
let json_strings = [ | ||
Some(r#"{"a": {"b": 2}, "b": 2, "c": 3}"#.to_string()), | ||
Some(r#"{"a": 1, "b": [1,2,3]}"#.to_string()), | ||
Some(r#"[1,2,3]"#.to_string()), | ||
Some(r#"{"a":1,"b":[1,2,3]}"#.to_string()), | ||
Some(r#"null"#.to_string()), | ||
Some(r#"null"#.to_string()), | ||
]; | ||
|
||
let results = [ | ||
Some(r#"["a","b","c"]"#), | ||
Some(r#"["a","b"]"#), | ||
None, | ||
Some(r#"["a","b"]"#), | ||
None, | ||
None, | ||
]; | ||
|
||
let jsonbs = json_strings | ||
.into_iter() | ||
.map(|s| s.map(|json| jsonb::parse_value(json.as_bytes()).unwrap().to_vec())) | ||
.collect::<Vec<_>>(); | ||
|
||
let json_vector = BinaryVector::from(jsonbs); | ||
let args: Vec<VectorRef> = vec![Arc::new(json_vector)]; | ||
let vector = json_object_keys | ||
.eval(FunctionContext::default(), &args) | ||
.unwrap(); | ||
|
||
assert_eq!(6, vector.len()); | ||
|
||
for (i, expected) in results.iter().enumerate() { | ||
let result = vector.get_ref(i); | ||
match expected { | ||
Some(expected_value) => { | ||
assert!(!result.is_null()); | ||
let result_value = result.as_string().unwrap().unwrap(); | ||
assert_eq!(*expected_value, result_value); | ||
} | ||
None => { | ||
assert!(result.is_null()); | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure whether it's a good idea to return string type here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String type seems to be the only choice for now, or we need to activate the list type first.