Implemented setStart and setEnd methods #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods adjust the start and end handles, respectively. This commit also changes the method signature for the updateLeftConstraint and updateRightConstraint methods to accept a CGFloat instead of a CGPoint. This simplifies my additions and I think also makes sense because the constraints are 1-dimensional.
|
@jacobbrunson Thanks for contributing ! There is a situation that has not been accounted for, when the duration of the asset is greater than the asset preview (controlled by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods adjust the start and end handles. I think this addresses #19 and/or #17
This PR also changes the method signature for the updateLeftConstraint and updateRightConstraint methods to accept a CGFloat instead of a CGPoint. This simplifies my additions and I think also makes sense because the constraints are 1-dimensional.