-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update set mzQC example #219
Conversation
I updated the example. @cbielow could you give it another review before merging? One thing to discuss is that I added the fraction unit for the protein contaminant fraction metric. However, in the CV this term doesn't have a unit specified. So I think we should still add it there. (Side note: the validator doesn't complain about this. Is this something that should be checked? @mwalzer) Another issue is that the file doesn't validate fully because it contains ID-based metrics, but the validator complains that we haven't listed any ID files as input.
|
Agreed.
Yes, proteinGroups.txt is correct. Which CV term you pick is arbitrary here, since the numbers are purely for illustration. Can stay as is IMHO.
Yes. |
Ready to be merged after psi-ms-CV#303 is merged to ensure that the CV version is accurate. |
* Update set mzQC for validator * Update set description * Add temporary accession number * Update example * Fix typo Co-authored-by: Chris Bielow <[email protected]> * Fix protein contaminant metric * Update the mzQC file as well * Update the OBO version * Updated CV term definition --------- Co-authored-by: Chris Bielow <[email protected]>
To update the mzQC set example, we need a few additional changes:
proteinGroups.txt
based on my limited knowledge of MaxQuant and the previous description. Does this make sense? There doesn't seem to be a dedicated entry for MaxQuant output files in the CV yet, so I've used a more generic one.