Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set mzQC example #219

Merged
merged 11 commits into from
Jul 29, 2024
Merged

Update set mzQC example #219

merged 11 commits into from
Jul 29, 2024

Conversation

bittremieux
Copy link
Collaborator

@bittremieux bittremieux commented Mar 19, 2024

To update the mzQC set example, we need a few additional changes:

  • There is no term for the old protein contaminant intensity ratio. I added an updated definition in the mzQC file itself, but I'm not familiar with this metric, so it should be double-checked. TODO: This still needs to be requested in the CV and then updated with the corresponding accession number here.
  • I updated the PCA table. This seems fine, except that it's an ID-based metric, so an ID input file has to be added. I've included the proteinGroups.txt based on my limited knowledge of MaxQuant and the previous description. Does this make sense? There doesn't seem to be a dedicated entry for MaxQuant output files in the CV yet, so I've used a more generic one.
    • The validator currently doesn't recognize this as an ID file.

@bittremieux
Copy link
Collaborator Author

bittremieux commented Jul 9, 2024

I updated the example. @cbielow could you give it another review before merging?

One thing to discuss is that I added the fraction unit for the protein contaminant fraction metric. However, in the CV this term doesn't have a unit specified. So I think we should still add it there.

(Side note: the validator doesn't complain about this. Is this something that should be checked? @mwalzer)

Another issue is that the file doesn't validate fully because it contains ID-based metrics, but the validator complains that we haven't listed any ID files as input.

  1. For the "all" set, we have included the proteinGroups.txt file, but the validator doesn't recognize this. @mwalzer can this be updated?
  2. Is this the correct input file considering that the metric we're using is "principal component analysis of MaxQuant's protein group raw intensities"? @cbielow I'm not familiar enough with MaxQuant's outputs. We also have another CV term that describes PCA results of MaxQuant's group lfq intensities.
  3. For the "healthy" and "diseased" sets, we indeed don't have an ID file listed. Should this be the same proteinGroups.txt file from MaxQuant @cbielow?

@bittremieux bittremieux requested a review from cbielow July 9, 2024 08:34
docs/pages/worked-examples/intro_set.md Outdated Show resolved Hide resolved
@cbielow
Copy link
Collaborator

cbielow commented Jul 9, 2024

One thing to discuss is that I added the fraction unit for the protein contaminant fraction metric. However, in the CV this term doesn't have a unit specified. So I think we should still add it there.

Agreed.

  1. Is this the correct input file considering that the metric we're using is "principal component analysis of MaxQuant's protein group raw intensities"? @cbielow I'm not familiar enough with MaxQuant's outputs. We also have another CV term that describes PCA results of MaxQuant's group lfq intensities.

Yes, proteinGroups.txt is correct. Which CV term you pick is arbitrary here, since the numbers are purely for illustration. Can stay as is IMHO.

For the "healthy" and "diseased" sets, we indeed don't have an ID file listed. Should this be the same proteinGroups.txt file from MaxQuant @cbielow?

Yes.

@bittremieux
Copy link
Collaborator Author

Ready to be merged after psi-ms-CV#303 is merged to ensure that the CV version is accurate.

@mwalzer mwalzer linked an issue Jul 25, 2024 that may be closed by this pull request
7 tasks
@bittremieux bittremieux merged commit b9a8345 into main Jul 29, 2024
1 check passed
@bittremieux bittremieux deleted the intro_set branch July 29, 2024 11:32
bittremieux added a commit that referenced this pull request Jan 10, 2025
* Update set mzQC for validator

* Update set description

* Add temporary accession number

* Update example

* Fix typo

Co-authored-by: Chris Bielow <[email protected]>

* Fix protein contaminant metric

* Update the mzQC file as well

* Update the OBO version

* Updated CV term definition

---------

Co-authored-by: Chris Bielow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants