Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix CRcvBufferNew::m_iStartSeqNo was not sync in group #2266

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

gou4shi1
Copy link
Contributor

Use m_RecvLock instead of m_RcvBufferLock since the above m_pRcvBuffer->applyGroupTime() is protected by m_RecvLock, maybe we should change to m_RcvBufferLock consistently?

@codecov-commenter

This comment was marked as off-topic.

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Mar 25, 2022
@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Mar 25, 2022
@maxsharabayko
Copy link
Collaborator

The m_RecvLock is intended to synchronise srt_recvmsg2(..) API calls between each other if called from multiple threads, and with the TSBPD thread, in particular, to exchange read-readiness state updates in the blocking mode. The mutex is indeed used in too many places to protect access to the receiver buffer, where m_RcvBufferLock must be used for that purpose instead.

@maxsharabayko
Copy link
Collaborator

Created a separate issue #2304 to address the use of the m_RecvLock mutex.

@maxsharabayko maxsharabayko merged commit c76f43d into Haivision:master Apr 21, 2022
@gou4shi1 gou4shi1 deleted the fix-m_iStartSeqNo branch April 21, 2022 11:09
@gou4shi1
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Priority: High Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants