-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix some warnings when compiling with mingw #2868
Conversation
Removed duplicate declaration of SRT_API Moved around variables to avoid set but not used warnings
Co-authored-by: Maxim Sharabayko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
===========================================
- Coverage 67.26% 48.81% -18.46%
===========================================
Files 103 141 +38
Lines 20460 23356 +2896
===========================================
- Hits 13763 11401 -2362
- Misses 6697 11955 +5258 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add srt.h include where needed
This causes ffmpeg can't find srt_compat.h when libsrt is enabled.
|
This include should not be there, it will be fixed soon |
fixes #2862
Removed duplicate declaration of SRT_API
Moved around variables to avoid set but not used warnings