[core] Fixed the RCV buffer non-read position update condition #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
condition in case of dropping upto a sequence number.
maxsharabayko
force-pushed
the
hotfix/rcv-drop-upto
branch
from
a9a92af to
d226f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the condition in the receiver buffer to update the first non-read position in case of dropping upto a sequence number.
Both
m_iFirstNonreadPosandm_iStartPosare positions in the RCV buffer, but were compared using theCSeqNo::seqcmpas if they were packet sequence numbers. This bug was causing an extra loop over packets in the receiver buffer to find the first gap. The position was restored correctly, but costs extra CPU resources.Mainly noticeable in a broadcast group connection, when a packet is read from one member, but dropped from all the rest members.