Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Prevent socket from being closed twice in EE test #2886

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ethouris
Copy link
Collaborator

This marks the socket extraordinarily closed to cancel pending connections as invalid, and therefore it won't be tried to be closed in teardown().

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Feb 21, 2024
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [tests] Area: Unit tests labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea8ea9f) 64.26% compared to head (df4ebeb) 64.39%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
+ Coverage   64.26%   64.39%   +0.12%     
==========================================
  Files         101      101              
  Lines       17480    17493      +13     
==========================================
+ Hits        11233    11264      +31     
+ Misses       6247     6229      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko merged commit 6b75145 into Haivision:master Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants