Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add an action to check API/ABI compatibility #2902

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

yomnes0
Copy link
Collaborator

@yomnes0 yomnes0 commented Mar 6, 2024

Add an action to check backward API/ABI compatibility

@yomnes0 yomnes0 marked this pull request as ready for review March 6, 2024 16:34
@yomnes0 yomnes0 added Type: Enhancement Indicates new feature requests [build] Area: Changes in build files labels Mar 6, 2024
@yomnes0 yomnes0 requested a review from maxsharabayko March 6, 2024 16:35
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.87%. Comparing base (12aad6e) to head (42e7f36).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2902      +/-   ##
==========================================
+ Coverage   64.72%   64.87%   +0.14%     
==========================================
  Files         101      101              
  Lines       17543    17523      -20     
==========================================
+ Hits        11355    11368      +13     
+ Misses       6188     6155      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Mar 6, 2024
branches: [ master ]

env:
SRT_BASE: v1.5.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used? Or needed to change value on the step "build"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there is any possible external file to provide the specific values. OTOH it will be rarely changed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the first way that came to my mind to transfer the tag version to the checkout action. It seems like "traditional" env variables are not shared between steps, and I couldn't get the ref from checkout@v3 to work properly by directly parsing the version there

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, then we better have a script to apply appropriate changes, or generate this file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be done by using a github secret that would be updated at each tag generation

@maxsharabayko maxsharabayko merged commit 84b5bb8 into Haivision:master Mar 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants