-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Add an action to check API/ABI compatibility #2902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2902 +/- ##
==========================================
+ Coverage 64.72% 64.87% +0.14%
==========================================
Files 101 101
Lines 17543 17523 -20
==========================================
+ Hits 11355 11368 +13
+ Misses 6188 6155 -33 ☔ View full report in Codecov by Sentry. |
branches: [ master ] | ||
|
||
env: | ||
SRT_BASE: v1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used? Or needed to change value on the step "build"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is any possible external file to provide the specific values. OTOH it will be rarely changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the first way that came to my mind to transfer the tag version to the checkout action. It seems like "traditional" env variables are not shared between steps, and I couldn't get the ref from checkout@v3 to work properly by directly parsing the version there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, then we better have a script to apply appropriate changes, or generate this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be done by using a github secret that would be updated at each tag generation
Add an action to check backward API/ABI compatibility