Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Migrate SonarCloud to GitHub Action (PR within the repo). #2910

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Mar 8, 2024

Fixes #2851.

TODO

  • CodeCoverage not found.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [build] Area: Changes in build files labels Mar 8, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Mar 8, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.81%. Comparing base (03aa5e4) to head (5241a20).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   64.97%   64.81%   -0.17%     
==========================================
  Files         101      101              
  Lines       17525    17522       -3     
==========================================
- Hits        11387    11357      -30     
- Misses       6138     6165      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
43.3% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ethouris
Copy link
Collaborator

I think there are some needed improvements:

  1. The code from the libsrtsupport and all testing applications should be excluded from checking.
  2. The C++ standard should be correctly applied to particular parts

I think the best would be if the checks focus exclusively on srtcore, haicrypt and common directories and defines C++03 as the C++ standard for all checks.

@maxsharabayko
Copy link
Collaborator Author

I think there are some needed improvements:

  1. The code from the libsrtsupport and all testing applications should be excluded from checking.
  2. The C++ standard should be correctly applied to particular parts

I think the best would be if the checks focus exclusively on srtcore, haicrypt and common directories and defines C++03 as the C++ standard for all checks.

The 1st should be done via Quality Profiles. Would be nice to apply C++03 on the core, but C++11 on apps.
Another topic is that Sonarcloud still likely does not check PRs submitted from external repos.

@maxsharabayko
Copy link
Collaborator Author

Merging to experiment with external PRs.

@maxsharabayko maxsharabayko merged commit 0a046d4 into master Mar 12, 2024
13 of 15 checks passed
@maxsharabayko maxsharabayko deleted the ci/sonar-cloud branch March 12, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate SonarCloud to a GitHub action.
2 participants