Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grading #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Grading #6

wants to merge 1 commit into from

Conversation

billmwong
Copy link
Collaborator

@billmwong billmwong commented Apr 15, 2017

Make sure to look at our Feedback.md file for your feedback and close this PR when done!

MiniProject Rubric (200 points total)

Functionality: 69/100

Completion: 54/80

  • 80 - You implemented all of the required features in the assignment. The assignment is complete
  • 60 - All major features were implemented. You didn't get to one or two small features.
  • 40 - Some of the required features were implemented.
  • 20 - An attempt was made to implement some of the of the desired features.
  • 0 - Very few or none of the desired features were implemented.

Oath not done, voting and results page are not done.

Bug free: 15/20

  • 20 - The app is bug free
  • 15 - Your app has one or two bugs, occasionally causing unexpected behavior
  • 10 - Your app has a couple bugs that a normal user would probably find.
  • 5 - Your app has many major bugs.
  • 0 - Your app has multiple bugs, frequently causing unexpected behavior.

Your app had a couple bugs. On the voting page, there were blank spaces for images, rankings, and prices because the component was expecting the whole object but only received names. If a user clicks “Create Event” before clicking the “Search” button, a link is generated that takes them to a blank page with an error about the map.

Design/Usability: 18/20 points

  • 20 - Pages are designed well, it is intuitive how to interact with the app. User-facing strings are descriptive. The app is for the most part aesthetically appealing.
  • 15 - A small part of the app was unintuitive to interact with or it was a bit ugly.
  • 10 - Information flow was unintuitive. It is difficult for a user to do what they want with your app.
  • 0 - Your app was unintuitive to the point of being unusable.

Quality: 58/80

Good coding practices: 35/40

  • 40 - Follow good naming conventions, use triple equals, use indents and whitespace where appropriate, know when to use global or local variables, etc.
  • 30 - Some of the above practices were broken, but you mostly followed good practices.
  • 20 - Many of the above practices were broken.
  • 10 - Most code did not follow good practices.
  • 0 - Good coding practices were consistently broken.

Mostly good, but indents were inconsistent, commented-out code was not deleted before submission.

Readability/Documentation: 23/40

  • 40 - Functions and variables are named well. Code is well commented where appropriate. Confusing lines are commented. Lines are not too long.
  • 30 - Code is occasionally confusing. Could use more comments. Some variables are poorly named.
  • 20 - Code is mostly confusing. Could use many more comments. Some variables are poorly named.
  • 10 - Code is very confusing. Needed many more comments. Variables are often poorly named.
  • 0 - Code is difficult to read. Other developers would not be able to use your code.

There were 3 comments that weren’t just commented out code, you mixed ES5 and ES6. The component that you described as “the add item form” was named “NewEvent.js”, so make sure you name things consistently and intuitively.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant