Fix pledge navigation not working when done too quickly

We do not need to care for lifecycle here, as the sliding event should only happen once anyway. And if we do not handle it otherwise the slider gets stuck at the end.
HedvigInsurance · Oct 21, 2023 · 542b8a0 · 542b8a0
1 parent 3bbf005
commit 542b8a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/app/app/src/main/kotlin/com/hedvig/android/app/navigation/HedvigNavHost.kt b/app/app/src/main/kotlin/com/hedvig/android/app/navigation/HedvigNavHost.kt
@@ -259,12 +259,8 @@ private fun NavGraphBuilder.nestedHomeGraphs(
     windowSizeClass = hedvigAppState.windowSizeClass,
     navigator = navigator,
     shouldShowRequestPermissionRationale = shouldShowRequestPermissionRationale,
-    navigateToTriaging = { backStackEntry ->
-      if (backStackEntry != null) {
-        with(navigator) { backStackEntry.navigate(ClaimTriagingDestination.ClaimGroups) }
-      } else {
-        navigator.navigateUnsafe(ClaimTriagingDestination.ClaimGroups)
-      }
+    navigateToTriaging = {
+      navigator.navigateUnsafe(ClaimTriagingDestination.ClaimGroups)
     },
     openAppSettings = {
       activityNavigator.openAppSettings(context)

diff --git a/...e-odyssey/src/main/kotlin/com/hedvig/android/feature/odyssey/navigation/ClaimFlowGraph.kt b/...e-odyssey/src/main/kotlin/com/hedvig/android/feature/odyssey/navigation/ClaimFlowGraph.kt
@@ -52,7 +52,7 @@ fun NavGraphBuilder.claimFlowGraph(
   windowSizeClass: WindowSizeClass,
   navigator: Navigator,
   shouldShowRequestPermissionRationale: (String) -> Boolean,
-  navigateToTriaging: (NavBackStackEntry?) -> Unit,
+  navigateToTriaging: () -> Unit,
   openAppSettings: () -> Unit,
   closeClaimFlow: () -> Unit,
   openChat: (NavBackStackEntry) -> Unit,
@@ -74,7 +74,7 @@ fun NavGraphBuilder.claimFlowGraph(
           with(navigator) { backStackEntry.navigate(ClaimFlowDestination.NotificationPermission) }
         },
         pledgeAccepted = {
-          navigateToTriaging(backStackEntry)
+          navigateToTriaging()
         },
         navigateUp = navigator::navigateUp,
         closeClaimFlow = closeClaimFlow,
@@ -84,9 +84,7 @@ fun NavGraphBuilder.claimFlowGraph(
       NotificationPermissionDestination(
         windowSizeClass = windowSizeClass,
         onNotificationPermissionDecided = {
-          // We need to navigate without checking lifecycle, since we want to navigate after accepting the permission.
-          // That dialog showing means that the app is not Resumed and would otherwise make us not navigate.
-          navigateToTriaging(null)
+          navigateToTriaging()
         },
         openAppSettings = openAppSettings,
         navigateUp = navigator::navigateUp,