Dark mode #1825
Merged
Dark mode #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows a bunch of our reusable components with a dark mode toggle
For dark mode, greyscale_800 should be used for the typing flicker instead.
Before, in the scenario where PSA was there but no member reminders, there was only a 8dp space between PSA and the buttons below which is wrong.
That color is white with black text in both themes
Remove some styles and instead just add a custom color for dark and light mode.
Chat toolbar still needs the color explicitly otherwise it will look transparent and hard to see
Bottom padding because it was touching the chat box. Top padding because it was now going behind the toolbar. This is not super nice, but again, when the XML is gone we will do it right
Before, since the lifecycle would not be resumed after trying to pop the backstack before going to the next destination, it would result in the chat navigation not happening. Using the right navigation API to do this in the first place, with the popUpTo builder function will make this work reliably
StylianosGakis
changed the base branch from
develop
to
fix/backend_breaking_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some migrations from LargeContainedTextButton to Hedvig*Button so that we don't use the purple colors.
And some special handling for chat due to it being in XML