Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking GQL changes #1826

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix breaking GQL changes #1826

merged 2 commits into from
Oct 12, 2023

Conversation

StylianosGakis
Copy link
Member

@StylianosGakis StylianosGakis commented Oct 12, 2023 •
edited
Loading

It seems like here

android/app/feature/feature-insurances/src/main/kotlin/com/hedvig/android/feature/insurances/data/GetInsuranceContractsUseCase.kt

Line 74 in 6480006

supportsAddressChange = true,
we want to in the future use this

android/app/apollo/apollo-octopus-public/src/main/graphql/com/hedvig/android/apollo/octopus/graphql/insurance/InsuranceContractsQuery.graphql

Line 18 in 6480006

supportsMoving
but moving flow is not out ATM.
If we need it to be out, maybe one thing to consider fixing as well @hugokallstrom

@StylianosGakis StylianosGakis requested a review from a team as a code owner October 12, 2023 14:34
@StylianosGakis StylianosGakis merged commit 55c7adb into develop Oct 12, 2023
4 checks passed
@StylianosGakis StylianosGakis deleted the fix/backend_breaking_changes branch October 12, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugokallstrom hugokallstrom hugokallstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StylianosGakis @hugokallstrom